From 5af5b6597b514ebfca674b955584bfabcb460842 Mon Sep 17 00:00:00 2001
From: Nils Andreas Svee <me@lochnair.net>
Date: Mon, 13 Apr 2026 15:28:56 +0700
Subject: [PATCH] feat(observability): report reflector selection events and
 outcomes

Emit metrics detailing why a reflector reselection was triggered and which peers were selected to improve selection process visibility.
---
 src/reflector_selector.rs | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/src/reflector_selector.rs b/src/reflector_selector.rs
index b118ef3..2ca4f56 100644
--- a/src/reflector_selector.rs
+++ b/src/reflector_selector.rs
@@ -1,7 +1,9 @@
 use crate::metrics::Metric;
+use crate::time::Time;
 use crate::util::{MutexExt, RwLockExt};
 use crate::{Config, ReflectorStats};
 use log::{debug, info};
+use rustix::time::ClockId;
 use std::collections::HashMap;
 use std::net::IpAddr;
 use std::sync::mpsc::{Receiver, SyncSender};
@@ -24,6 +26,7 @@ impl ReflectorSelector {
         let mut reselection_count = 0;
         let baseline_sleep_time =
             Duration::from_secs_f64(self.config.tick_interval * std::f64::consts::PI);
+        let clock = Time::new(ClockId::Realtime);
 
         // Initial wait of several seconds to allow some OWD data to build up
         sleep(baseline_sleep_time);
@@ -34,10 +37,10 @@ impl ReflectorSelector {
              * or it passes the timeout. In any case we don't care about the result of this function,
              * so we ignore the result of it.
              */
-            let _ = self
+            let triggered = self
                 .trigger_channel
                 .recv_timeout(selector_sleep_time)
-                .unwrap_or(true);
+                .is_ok();
             reselection_count += 1;
             info!("Starting reselection [#{}]", reselection_count);
 
@@ -127,7 +130,24 @@ impl ReflectorSelector {
                 );
             }
 
-            *reflectors_peers = new_peers;
+            *reflectors_peers = new_peers.clone();
+
+            if let Some(ref tx) = self.metrics_tx {
+                let _ = tx.try_send(Metric::Event {
+                    name: "reflector_selection",
+                    reason: if triggered { "triggered" } else { "timeout" },
+                    reflector: None,
+                    timestamp_ns: clock.as_nanos(),
+                });
+                for peer in &new_peers {
+                    let _ = tx.try_send(Metric::Event {
+                        name: "reflector_selected",
+                        reason: "",
+                        reflector: Some(*peer),
+                        timestamp_ns: clock.as_nanos(),
+                    });
+                }
+            }
         }
     }
 }