Lochnair-Labs/irtt-rs
2
0 Fork 0
Code Issues 1 Pull Requests 4 Actions 8 Packages Projects Releases 6 Wiki Activity

refactor(client): move probe scheduling out of SessionMachine #40

Merged
Lochnair merged 2 commits from refactor/probe-scheduling into main 2026-08-03 17:16:21 +00:00
Conversation 0 Commits 2 Files Changed 7
+516 -285
Lochnair commented 2026-08-03 17:13:17 +00:00 (Migrated from github.com)
Copy link
Copy source

Summary

Move probe cadence and finite-run scheduling from SessionMachine into a
crate-private ProbeSchedule owned by the blocking client and each managed
target.

Architectural rationale

SessionMachine now owns only protocol lifecycle, sequence allocation, pending
probes, reply classification, and terminal protocol state. Scheduling deadlines,
finite-run boundaries, cadence advancement, and missed-slot handling have one
separate owner.

This preserves absolute opening-time cadence, exclusive finite-run completion,
missed-slot skipping, and the requirement to drain pending replies after the
final scheduled send.

Test stabilization

Replace the burst and staggered pacing tests' opposing 20 ms loopback thresholds
with deterministic explicit-Instant assertions over private scheduling
helpers. Existing loose multi-target loopback smoke coverage remains.

Testing

  • cargo fmt --all -- --check
  • cargo check --workspace
  • cargo test --workspace
  • cargo test -p irtt-client --no-default-features
  • cargo clippy -p irtt-client --all-targets --no-default-features -- -D warnings
  • Focused managed pacing, delayed pacing, target-update, finite-run, and
    pending-reply tests
  • Five repeated passes of both deterministic pacing replacements
## Summary Move probe cadence and finite-run scheduling from `SessionMachine` into a crate-private `ProbeSchedule` owned by the blocking client and each managed target. ## Architectural rationale `SessionMachine` now owns only protocol lifecycle, sequence allocation, pending probes, reply classification, and terminal protocol state. Scheduling deadlines, finite-run boundaries, cadence advancement, and missed-slot handling have one separate owner. This preserves absolute opening-time cadence, exclusive finite-run completion, missed-slot skipping, and the requirement to drain pending replies after the final scheduled send. ## Test stabilization Replace the burst and staggered pacing tests' opposing 20 ms loopback thresholds with deterministic explicit-`Instant` assertions over private scheduling helpers. Existing loose multi-target loopback smoke coverage remains. ## Testing - `cargo fmt --all -- --check` - `cargo check --workspace` - `cargo test --workspace` - `cargo test -p irtt-client --no-default-features` - `cargo clippy -p irtt-client --all-targets --no-default-features -- -D warnings` - Focused managed pacing, delayed pacing, target-update, finite-run, and pending-reply tests - Five repeated passes of both deterministic pacing replacements
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Lochnair renovate (Renovate Bot) Bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Lochnair-Labs/irtt-rs#40