Lochnair-Labs/irtt-rs
2
0 Fork 0
Code Issues 1 Pull Requests 4 Actions 4 Packages Projects Releases 6 Wiki Activity

Make session lifecycle state explicit #38

Merged
Lochnair merged 2 commits from refactor/session-machine-state into main 2026-08-03 16:41:59 +00:00
Conversation 0 Commits 2 Files Changed 6
+147 -146
Lochnair commented 2026-08-03 16:37:32 +00:00 (Migrated from github.com)
Copy link
Copy source

Summary

  • Move the private session runtime into the session module.
  • Separate parameter negotiation into session/negotiation.rs.
  • Rename SessionRuntime to SessionMachine.
  • Replace parallel optional lifecycle fields with one explicit private MachineState.
  • Box the open-session payload to satisfy strict Clippy size checks.

Architectural rationale

Representing connected, open, no-test-completed, and closed states as enum
variants makes contradictory lifecycle combinations unrepresentable. Open-only
state is owned by ActiveSession, while terminal packet counts remain available
after close. Public exports and observable behavior remain unchanged.

Testing

  • cargo fmt --all -- --check
  • cargo check --workspace
  • cargo test --workspace
  • cargo check -p irtt-client --no-default-features
  • cargo test -p irtt-client --no-default-features
  • cargo clippy -p irtt-client --all-targets --no-default-features -- -D warnings
  • git diff --check
## Summary - Move the private session runtime into the session module. - Separate parameter negotiation into `session/negotiation.rs`. - Rename `SessionRuntime` to `SessionMachine`. - Replace parallel optional lifecycle fields with one explicit private `MachineState`. - Box the open-session payload to satisfy strict Clippy size checks. ## Architectural rationale Representing connected, open, no-test-completed, and closed states as enum variants makes contradictory lifecycle combinations unrepresentable. Open-only state is owned by `ActiveSession`, while terminal packet counts remain available after close. Public exports and observable behavior remain unchanged. ## Testing - `cargo fmt --all -- --check` - `cargo check --workspace` - `cargo test --workspace` - `cargo check -p irtt-client --no-default-features` - `cargo test -p irtt-client --no-default-features` - `cargo clippy -p irtt-client --all-targets --no-default-features -- -D warnings` - `git diff --check`
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Lochnair renovate (Renovate Bot) Bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Lochnair-Labs/irtt-rs#38