From c7d03c03581007b57f21d1405c8d28faec6d8b72 Mon Sep 17 00:00:00 2001 From: Nils Andreas Svee Date: Sat, 20 Jun 2026 23:08:00 +0700 Subject: [PATCH] test(client): strengthen assertions for session cleanup after peer closure Update tests to ensure no packets at all are sent following a peer-initiated closure, rather than just checking for the absence of the close flag. --- crates/irtt-cli/src/shared/client/session.rs | 10 +++++----- crates/irtt-client/src/managed/runner.rs | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/crates/irtt-cli/src/shared/client/session.rs b/crates/irtt-cli/src/shared/client/session.rs index 5dbaa85..114457f 100644 --- a/crates/irtt-cli/src/shared/client/session.rs +++ b/crates/irtt-cli/src/shared/client/session.rs @@ -288,11 +288,11 @@ mod tests { socket .set_read_timeout(Some(Duration::from_millis(250))) .unwrap(); - while let Some((packet, _)) = recv_request_timeout(&socket) { - assert_eq!( - packet[3] & flags::FLAG_CLOSE, - 0, - "session cleanup must not send a close after peer close" + if let Some((packet, _)) = recv_request_timeout(&socket) { + panic!( + "session cleanup must not send any packet after peer close; flags={:?} len={}", + packet.get(3).copied(), + packet.len() ); } }); diff --git a/crates/irtt-client/src/managed/runner.rs b/crates/irtt-client/src/managed/runner.rs index f24ab12..7f1de6e 100644 --- a/crates/irtt-client/src/managed/runner.rs +++ b/crates/irtt-client/src/managed/runner.rs @@ -532,11 +532,11 @@ mod tests { ) .unwrap(); - while let Some((packet, _)) = recv_request_timeout(&socket) { - assert_eq!( - packet[3] & flags::FLAG_CLOSE, - 0, - "managed cleanup must not send a close after peer close" + if let Some((packet, _)) = recv_request_timeout(&socket) { + panic!( + "managed cleanup must not send any packet after peer close; flags={:?} len={}", + packet.get(3).copied(), + packet.len() ); } });