From 665f8393336e9a0c552f70f9480b7279d7994648 Mon Sep 17 00:00:00 2001 From: Nils Andreas Svee Date: Sat, 15 Aug 2026 01:49:22 +0700 Subject: [PATCH] test(client): drop the coverage-only classification enumeration The removed test only checked that every failure kind appeared somewhere in the same hand-maintained case table the mapping test already walks. It could not prove exhaustiveness or the absence of a fallback, which the compiler enforces, and it pinned the incidental fact that each category currently has an input. --- crates/irtt-client/src/managed/model.rs | 26 ------------------------- 1 file changed, 26 deletions(-) diff --git a/crates/irtt-client/src/managed/model.rs b/crates/irtt-client/src/managed/model.rs index 57c7cd8..7bb92d3 100644 --- a/crates/irtt-client/src/managed/model.rs +++ b/crates/irtt-client/src/managed/model.rs @@ -592,32 +592,6 @@ mod tests { } } - #[test] - fn classification_covers_every_failure_kind_except_other() { - let observed: Vec<_> = classification_cases() - .into_iter() - .map(|(error, _)| { - classify_client_error(ManagedTargetFailurePhase::Sending, &error).kind - }) - .collect(); - for kind in [ - ManagedTargetFailureKind::Resolve, - ManagedTargetFailureKind::Socket, - ManagedTargetFailureKind::SocketOption, - ManagedTargetFailureKind::Protocol, - ManagedTargetFailureKind::Timeout, - ManagedTargetFailureKind::Configuration, - ManagedTargetFailureKind::ResourceExhausted, - ManagedTargetFailureKind::InvalidState, - ] { - assert!(observed.contains(&kind), "no case classifies as {kind}"); - } - assert!( - !observed.contains(&ManagedTargetFailureKind::Other), - "Other must remain a deliberate category, not a fallback" - ); - } - #[test] fn classification_preserves_the_reported_phase() { for phase in [