tests: rework the actually useful tests to live in the integration crate

crates/irtt-app/src/cmd/server/run.rs

@@ -105,105 +105,3 @@ async fn shutdown_signal(shutdown_requested: &AtomicBool) {
         tokio::time::sleep(SHUTDOWN_POLL_INTERVAL).await;
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use clap::Parser;
-
-    use super::*;
-    use crate::cmd::server::env_lock::with_env_lock;
-
-    /// The ordinary invocation, and the one that keeps the single-listener case
-    /// on the same orchestration path as every other.
-    #[test]
-    fn an_already_requested_shutdown_binds_one_listener_and_returns() {
-        let args = with_env_lock(|| {
-            ServerArgs::try_parse_from(["irtt-server", "--bind", "127.0.0.1:0"]).unwrap()
-        });
-        let shutdown_requested = AtomicBool::new(true);
-
-        run_server(args, &shutdown_requested).unwrap();
-    }
-
-    #[test]
-    fn an_already_requested_shutdown_binds_every_listener_and_returns() {
-        let args = with_env_lock(|| {
-            ServerArgs::try_parse_from([
-                "irtt-server",
-                "--bind",
-                "127.0.0.1:0",
-                "--bind",
-                "127.0.0.1:0",
-            ])
-            .unwrap()
-        });
-        let shutdown_requested = AtomicBool::new(true);
-
-        run_server(args, &shutdown_requested).unwrap();
-    }
-
-    fn default_binds() -> Vec<SocketAddr> {
-        with_env_lock(|| {
-            ServerArgs::try_parse_from(["irtt-server"])
-                .unwrap()
-                .resolve_binds()
-        })
-    }
-
-    #[test]
-    fn implicit_default_losing_an_unsupported_family_falls_back_to_the_other() {
-        let binds = default_binds();
-        let failed = binds[0];
-
-        let remaining = implicit_default_fallback(true, false, &binds, failed).unwrap();
-
-        assert_eq!(remaining, [binds[1]]);
-    }
-
-    #[test]
-    fn a_supported_familys_failure_never_falls_back() {
-        // The family itself works fine here; whatever made this specific
-        // bind fail (port in use, permission, ...) is a real problem this
-        // invocation should surface, not paper over.
-        let binds = default_binds();
-
-        assert_eq!(
-            implicit_default_fallback(true, true, &binds, binds[0]),
-            None,
-            "family_available: true means this is not a family-support problem"
-        );
-    }
-
-    #[test]
-    fn explicit_binds_never_fall_back() {
-        let binds = default_binds();
-
-        assert_eq!(
-            implicit_default_fallback(false, false, &binds, binds[0]),
-            None
-        );
-    }
-
-    #[test]
-    fn a_failure_outside_the_requested_set_does_not_fall_back() {
-        let binds = default_binds();
-        let unrelated = SocketAddr::from(([127, 0, 0, 1], 2113));
-
-        assert_eq!(
-            implicit_default_fallback(true, false, &binds, unrelated),
-            None,
-            "the failing address must actually be one this invocation asked for"
-        );
-    }
-
-    #[test]
-    fn losing_the_only_remaining_default_address_does_not_fall_back() {
-        let single = [SocketAddr::from(([0, 0, 0, 0], 2112))];
-
-        assert_eq!(
-            implicit_default_fallback(true, false, &single, single[0]),
-            None,
-            "no address would be left to retry with"
-        );
-    }
-}