tests: rework the actually useful tests to live in the integration crate

crates/irtt-app/src/cmd/client/output.rs

@@ -1205,183 +1205,3 @@ fn write_json_string_content(out: &mut String, value: &str) {
         }
     }
 }
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use irtt_client::ClientTimestamp;
-    use std::{
-        net::{IpAddr, Ipv4Addr, SocketAddr},
-        time::Instant,
-    };
-
-    fn output_config(format: OutputFormat, columns: Option<&str>) -> OutputConfig {
-        OutputConfig::new(format, columns, HeaderMode::Auto, false).unwrap()
-    }
-
-    fn remote() -> SocketAddr {
-        SocketAddr::new(IpAddr::V4(Ipv4Addr::LOCALHOST), 2112)
-    }
-
-    fn reply() -> ClientEvent {
-        let sent_at = ClientTimestamp {
-            wall: UNIX_EPOCH + Duration::from_secs(1),
-            mono: Instant::now(),
-        };
-        let received_at = ClientTimestamp {
-            wall: sent_at.wall + Duration::from_micros(1200),
-            mono: sent_at.mono + Duration::from_micros(1200),
-        };
-        ClientEvent::EchoReply {
-            seq: 7,
-            remote: remote(),
-            sent_at,
-            received_at,
-            rtt: RttSample {
-                raw: Duration::from_micros(1200),
-                adjusted: None,
-                effective: SignedDuration::from_nanos(1_200_000),
-            },
-            server_timing: None,
-            one_way: None,
-            received_stats: None,
-            bytes: 64,
-            packet_meta: PacketMeta::default(),
-        }
-    }
-
-    #[test]
-    fn list_columns_includes_target() {
-        assert!(OutputConfig::list_columns().contains("target"));
-    }
-
-    #[test]
-    fn default_table_columns_always_include_target_first() {
-        let header = output_config(OutputFormat::Table, None)
-            .render_header()
-            .unwrap();
-
-        assert_eq!(header.split_whitespace().next(), Some("target"));
-    }
-
-    #[test]
-    fn columns_default_keyword_matches_omitted_columns() {
-        for format in [
-            OutputFormat::Table,
-            OutputFormat::Csv,
-            OutputFormat::Tsv,
-            OutputFormat::Jsonl,
-        ] {
-            let omitted = output_config(format, None).render_header();
-            let explicit = output_config(format, Some("default")).render_header();
-            assert_eq!(omitted, explicit);
-        }
-    }
-
-    #[test]
-    fn custom_columns_do_not_insert_target() {
-        let config = output_config(OutputFormat::Csv, Some("seq,effective_rtt_us"));
-        let header = config.render_header().unwrap();
-
-        assert!(!header.split(',').any(|column| column == "target"));
-    }
-
-    #[test]
-    fn custom_target_column_renders_label() {
-        let config = output_config(OutputFormat::Csv, Some("target,seq,effective_rtt_us"));
-        let line = config
-            .render_event(&reply(), Some("ams"), Some(&EventRenderStats::default()))
-            .unwrap();
-
-        assert_eq!(
-            config.render_header().as_deref(),
-            Some("target,seq,effective_rtt_us")
-        );
-        assert_eq!(line, "ams,7,1200");
-    }
-
-    #[test]
-    fn default_csv_renders_target_label_in_row() {
-        let config = output_config(OutputFormat::Csv, None);
-        let line = config
-            .render_event(&reply(), Some("ams"), Some(&EventRenderStats::default()))
-            .unwrap();
-
-        assert_eq!(line.split(',').next(), Some("ams"));
-    }
-
-    #[test]
-    fn default_jsonl_renders_target_key_first() {
-        let config = output_config(OutputFormat::Jsonl, None);
-        let line = config
-            .render_event(&reply(), Some("ams"), Some(&EventRenderStats::default()))
-            .unwrap();
-
-        assert!(line.starts_with("{\"target\":\"ams\""));
-    }
-
-    #[test]
-    fn table_row_with_long_target_keeps_next_column_aligned() {
-        let config = output_config(OutputFormat::Table, None);
-        let header = config.render_header().unwrap();
-        let event_offset = header.find("event").unwrap();
-
-        for label in ["ams".to_owned(), "a".repeat(40), "é".repeat(40)] {
-            let line = config
-                .render_event(&reply(), Some(&label), Some(&EventRenderStats::default()))
-                .unwrap();
-            let prefix = line.split("echo_reply").next().unwrap();
-            assert_eq!(prefix.chars().count(), event_offset, "{line}");
-            if label.chars().count() > event_offset {
-                assert!(prefix.trim_end().ends_with("..."), "{line}");
-            } else {
-                assert!(prefix.starts_with(&label), "{line}");
-            }
-        }
-    }
-
-    #[test]
-    fn csv_preserves_full_long_target_label() {
-        let config = output_config(OutputFormat::Csv, Some("target,seq"));
-        let long_target = "a".repeat(40);
-        let line = config
-            .render_event(
-                &reply(),
-                Some(&long_target),
-                Some(&EventRenderStats::default()),
-            )
-            .unwrap();
-
-        assert_eq!(line, format!("{long_target},7"));
-    }
-
-    #[test]
-    fn tsv_preserves_full_long_target_label() {
-        let config = output_config(OutputFormat::Tsv, Some("target,seq"));
-        let long_target = "b".repeat(40);
-        let line = config
-            .render_event(
-                &reply(),
-                Some(&long_target),
-                Some(&EventRenderStats::default()),
-            )
-            .unwrap();
-
-        assert_eq!(line, format!("{long_target}\t7"));
-    }
-
-    #[test]
-    fn jsonl_preserves_full_long_target_label() {
-        let config = output_config(OutputFormat::Jsonl, Some("target,seq"));
-        let long_target = "c".repeat(40);
-        let line = config
-            .render_event(
-                &reply(),
-                Some(&long_target),
-                Some(&EventRenderStats::default()),
-            )
-            .unwrap();
-
-        assert_eq!(line, format!("{{\"target\":\"{long_target}\",\"seq\":7}}"));
-    }
-}